Re: [PATCH] [Cleanup] memcg: export memory cgroup's swappiness v2

From: KAMEZAWA Hiroyuki
Date: Thu Jun 30 2011 - 21:37:23 EST


On Fri, 1 Jul 2011 10:16:24 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:

> On Thu, 30 Jun 2011 18:06:53 -0700
> Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> > On Fri, 1 Jul 2011 09:20:59 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:
> >
> > > On Fri, 1 Jul 2011 08:50:13 +0900
> > > KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:
> > >
> > > > On Thu, 30 Jun 2011 13:01:34 -0700
> > > > Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > > Ok, I'll check it. Maybe I miss !CONFIG_SWAP...
> > > >
> > >
> > > v4 here. Thank you for pointing out. I could think of several ways but
> > > maybe this one is good because using vm_swappines with !CONFIG_SWAP seems
> > > to be a bug.
> >
> > No, it isn't a bug - swappiness also controls the kernel's eagerness to
> > unmap and reclaim mmapped pagecache.
> >
>
> Oh, really ? I didn't understand that.
>
Hmm, anyway, this new version of fix seems better.
==