Re: [RFC][PATCH] kprobes: Add separate preempt_disabling forkprobes

From: Peter Zijlstra
Date: Thu Jun 30 2011 - 17:57:53 EST


On Thu, 2011-06-30 at 11:51 -0400, Steven Rostedt wrote:
>
> To solve this, I've added a per_cpu variable called
> kprobe_preempt_disabled, that is set by the kprobe code. If it is set,
> the preempt_schedule() will not preempt the code.

Damn this is ugly. Can we step back and see if we can make the
requirement for kprobe to disable preemption go away?

Why does it have to do that anyway? Isn't it keeping enough per-task
state to allow preemption over the single step?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/