Re: [PATCH v2 2/5] Samsung SoC ADC: Channel selection for S5PV210,S5PC110, and Exynos4

[MyungJoo Ham]

On Wed, Jun 29, 2011 at 10:42 PM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote:
> MyungJoo Ham wrote:
>>
>> In S5PV210/S5PC110/Exynos4, ADCMUX channel selection uses ADCMUX
>> register, not ADCCON register. This patch corrects the behavior of
>> Samsung-ADC for such cpus.
>>
>> Signed-off-by: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
>> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
>> --
>> v2: No changes from v1. Resubmitted as a series of patches
>> ---
[]
>>
>> Âenum s3c_cpu_type {
>> Â Â Â TYPE_S3C24XX,
>> - Â Â TYPE_S3C64XX
>> + Â Â TYPE_S3C64XX,
>> + Â Â TYPE_S5P,
>> Â};
>
> How about S5PC100? Following is better for next if we cannot distinguish it
> by CPU.
>
> -enum s3c_cpu_type {
> - Â Â Â TYPE_S3C24XX,
> - Â Â Â TYPE_S3C64XX
> +enum samsung_adc_type {
> + Â Â Â TYPE_ADC24, Â Â Â/* S3C24XX */
> + Â Â Â TYPE_ADC64, Â Â Â/* S3C64XX, S5P64X0, S5PC100 */
> + Â Â Â TYPE_ADCV3 Â Â Â/* S5PV210, EXYNOS4210 */
> Â};
> ...
>
> TYPE_ADCV1 and V2?...
> Of course, the name can be changed...

I don't mind about these names as they are just internal values of adc.c.
Anyway, I prefer the last suggestion and I'll use TYPE_ADCV1/V2/V3.

Thanks.

-- 
MyungJoo Ham (íëì), Ph.D.
Mobile Software Platform Lab,
Digital Media and Communications (DMC) Business
Samsung Electronics
cell: 82-10-6714-2858
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/