Re: [PATCH] [Cleanup] memcg: export memory cgroup's swappiness v2

[KAMEZAWA Hiroyuki]

On Wed, 29 Jun 2011 13:00:43 -0700
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Wed, 29 Jun 2011 19:03:25 +0900
> KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:
> 
> > Each memory cgroup has 'swappiness' value and it can be accessed by
> > get_swappiness(memcg). The major user is try_to_free_mem_cgroup_pages()
> > and swappiness is passed by argument. It's propagated by scan_control.
> > 
> > get_swappiness is static function but some planned updates will need to
> > get swappiness from files other than memcontrol.c
> > This patch exports get_swappiness() as mem_cgroup_swappiness().
> > By this, we can remove the argument of swapiness from try_to_free...
> > and drop swappiness from scan_control. only memcg uses it.
> > 
> 
> > +extern unsigned int mem_cgroup_swappiness(struct mem_cgroup *mem);
> > +unsigned int mem_cgroup_swappiness(struct mem_cgroup *memcg)
> > +static int vmscan_swappiness(struct scan_control *sc)
> 
> The patch seems a bit confused about the signedness of swappiness.
> 

ok, v3 here. Now, memcg's one use "int" because vm_swapiness is "int".
==