Re: [PATCH] writeback: Don't wait for completion inwriteback_inodes_sb_nr

From: Christoph Hellwig
Date: Wed Jun 29 2011 - 16:12:45 EST


On Wed, Jun 29, 2011 at 09:15:18PM +0200, Jan Kara wrote:
> True but writeback_single_inode() has in it:
> if (wbc->sync_mode == WB_SYNC_ALL) {
> int err = filemap_fdatawait(mapping);
> if (ret == 0)
> ret = err;
> }
> So we end up waiting much earlier. Probably we should remove this wait
> but that will need some audit I guess.

Uhh, indeed. We'll need this wait for things like sync_inode, though.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/