Re: [PATCH 1/3] char drivers: ramoops default platform device formodule parameter use

[Daniel Baluta]

> +struct platform_device *ramoops_device;

This should be static.

> +
>  static int __init ramoops_init(void)
>  {
> +       /*
> +        * If mem_address and mem_size are set (i.e. the module parameters
> +        * are used) then a default platform driver is created
> +        * as there is no need to configure the platform data elsewhere.
> +        */
> +       if (mem_address && mem_size) {
You should get back to this check after introducing record_size.

thanks,
Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/