Re: [PATCH 2/2] mm: Document handle_mm_fault()

From: Linus Torvalds
Date: Tue Jun 28 2011 - 13:13:01 EST


On Tue, Jun 28, 2011 at 9:47 AM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> + * Note: if @flags has FAULT_FLAG_ALLOW_RETRY set then the mmap_sem
> + *       may be released if it failed to arquire the page_lock. If the
> + *       mmap_sem is released then it will return VM_FAULT_RETRY set.
> + *       This is to keep the time mmap_sem is held when the page_lock
> + *       is taken for IO.

So I know what that flag does, but I knew it without the comment.

WITH the comment, I'm just confused. "This is to keep the time
mmap_sem is held when the page_lock is taken for IO."

Sounds like a google translation from swahili. "keep the time" what?

Maybe "keep" -> "minimize"? Or just "This is to avoid holding mmap_sem
while waiting for IO"

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/