Re: [PATCH] perf, x86: Add hw_watchdog_set_attr() in a sake ofnmi-watchdog on P4

[Stephane Eranian]

On Mon, Jun 27, 2011 at 9:32 PM, Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:
>
> On Mon, Jun 27, 2011 at 03:03:58PM -0400, Don Zickus wrote:
> ...
> >
> > > Index: linux-2.6.git/kernel/watchdog.c
> > > ===================================================================
> > > --- linux-2.6.git.orig/kernel/watchdog.c
> > > +++ linux-2.6.git/kernel/watchdog.c
> > > @@ -200,6 +200,8 @@ static int is_softlockup(unsigned long t
> > > Â}
> > >
> > > Â#ifdef CONFIG_HARDLOCKUP_DETECTOR
> > > +void __weak hw_nmi_watchdog_set_attr(struct perf_event_attr *wd_attr) { }
> > > +
> >
> > Though I do wonder about this call in the watchdog. ÂI thought it might be
> > better elsewhere but not sure where.
>
> Yeah, not the _best_ place. Not sure too where to put it, patches are welcome ;)
>
No matter what, this file has to remain in a file that's common to all arch.

> >
> > Cheers,
> > Don
>
> Â Â Â ÂCyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/