Re: [PATCH 3/3] char drivers: ramoops record_size module parameter

[Marco Stornelli]

Hi,

2011/6/28 Sergiu Iordache <sergiu@xxxxxxxxxxxx>:
> The size of the dump is currently set using the RECORD_SIZE macro which
> is set to a page size. This patch makes the record size a module
> parameter and allows it to be set through platform data as well to allow
> larger dumps if needed.
>
> Change-Id: Ie6bd28a898dab476abf34decb0eecc42122f17ce
> Signed-off-by: Sergiu Iordache <sergiu@xxxxxxxxxxxx>
> ---

the idea can be valid, but you have to add some check to set the
record size. It'd be better to add a lower and upper bound and to
check for it's power of two.

Marco
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/