Re: [PATCH -next] bcma: main.c needs to include <linux/slab.h>

[Geert Uytterhoeven]

2011/6/27 RafaÅ MiÅecki <zajec5@xxxxxxxxx>:
> 2011/6/26 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>:
>> m68k allmodconfig:
>>
>> drivers/bcma/main.c: In function âbcma_release_core_devâ:
>> drivers/bcma/main.c:68: error: implicit declaration of function âkfreeâ
>
> We already include slab.h in:
> host_pci.c
> scan.c
> sprom.c
>
> Maybe we can just include this in bcma.h as a better solution? We
> could drop other includes then.
> Can you submit patch for this?

If bcma.h doesn't use linux/slab.h, IMHO it should not include linux/slab.h.

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/