Re: [RFC PATCH] irq: add irq_domain translation infrastructure

[Sebastian Andrzej Siewior]

* Grant Likely | 2011-05-26 00:54:38 [-0600]:

>diff --git a/arch/x86/kernel/devicetree.c b/arch/x86/kernel/devicetree.c
>index 39645b6..9891cd4 100644
>--- a/arch/x86/kernel/devicetree.c
>+++ b/arch/x86/kernel/devicetree.c
>@@ -371,36 +321,49 @@ static struct of_ioapic_type of_ioapic_type[] =
> 	},
> };
> 
>-static int ioapic_xlate(struct irq_domain *id, const u32 *intspec, u32 intsize,
>-			u32 *out_hwirq, u32 *out_type)
>+static int ioapic_dt_translate(struct irq_domain *domain,
>+				struct device_node *controller,
>+				const u32 *intspec, u32 intsize,
>+				irq_hw_number_t *out_hwirq, u32 *out_type)
> {
>-	struct mp_ioapic_gsi *gsi_cfg;
> 	struct io_apic_irq_attr attr;
> 	struct of_ioapic_type *it;
> 	u32 line, idx, type;
>+	int rc;
> 
>-	if (intsize < 2)
>+	if (controller != domain->of_node)
> 		return -EINVAL;

Is there a reason not havining the (controller != domain->of_node) check
in irq_create_of_mapping()?

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/