Re: [PATCH 2/4] ARM: use new LEDS CPU trigger stub to replace old one

From: Linus Walleij
Date: Sun Jun 26 2011 - 07:09:29 EST


Hi Bryan, notice that this:

2011/6/26 Bryan Wu <bryan.wu@xxxxxxxxxxxxx>:

> -               leds_event(led_idle_start);
> +               ledtrig_cpu(CPU_LED_IDLE_START);
(...)
> -               leds_event(led_idle_end);
> +               ledtrig_cpu(CPU_LED_IDLE_END);

That breaks all the old users of the CPU activity LEDs.

I only fixed up RealView and Versatile!

grep -r led_idle_start arch/arm/

Gives you a hint that you also have to retire custom LEDs from
orion, omap, at91, footbridge, sa1100, ks8695, shark, clps711x,
pxa and omap1.

You have to write a patch each an every one of these, and
since they all are already using that mechanism actively
you need to select the LED trigger in their Kconfig.

Thanks,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/