Re: [PATCH] regulator: twl: Add 'fixed' set_voltage callback

[Jaswinder Singh]

On 24 June 2011 16:49, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, Jun 24, 2011 at 02:16:54AM +0530, Jassi Brar wrote:
>> Define dummy set_voltage callback for fixed lines,
>> without which voltage constraints fail to apply.
>>
>> Signed-off-by: Jassi Brar <jaswinder.singh@xxxxxxxxxx>
>
> No, this isn't sensible - fixed voltage regulators aren't an unusual
> property of this device, they've very common. ÂThe core should handle
> this gracefully. ÂProbably whatever consumer is doing the setting also
> ought to be updated to check that the voltages it wants to set are
> supported at startup since

Well, there's no consumer in the picture yet. The core even fails to register
the regulator.
After digging deeper, I realized removing
       .apply_uV = true;
from the constraints is the correct solution. Patch is coming next.

> otherwise it can end up repeatedly trying to
> set something that'll never work.
Though the semantic could be defined that the 'closest' possible value
is already
set after the set_{voltage,current_limit} returns.
The consumer has no point in retrying - just like sample-rate setting
in Alsa works.

Thanks,
Jassi

-- 
Linaro.org â Open source software for ARM SoCs | Follow Linaro
http://facebook.com/pages/Linaro/155974581091106 Â-
http://twitter.com/#!/linaroorg - http://linaro.org/linaro-blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/