Re: [PATCH 0/3 v3] rcu: Detect rcu uses under extended quiescentstate

From: Frederic Weisbecker
Date: Fri Jun 24 2011 - 07:20:58 EST


On Thu, Jun 23, 2011 at 08:53:11PM -0700, Paul E. McKenney wrote:
> On Fri, Jun 24, 2011 at 01:12:37AM +0200, Frederic Weisbecker wrote:
> > This time I have no current practical cases to fix. Those I fixed
> > in previous versions were actually using rcu_dereference_raw(), which
> > is legal in extended qs.
> >
> > Frederic Weisbecker (3):
> > rcu: Detect illegal rcu dereference in extended quiescent state
> > rcu: Inform the user about dynticks idle mode on PROVE_RCU warning
> > rcu: Warn when rcu_read_lock() is used in extended quiescent state
> >
> > include/linux/rcupdate.h | 68 +++++++++++++++++++++++++++++++++++++++-------
> > kernel/lockdep.c | 4 +++
> > kernel/rcupdate.c | 4 +++
> > kernel/rcutiny.c | 13 +++++++++
> > kernel/rcutree.c | 14 +++++++++
> > 5 files changed, 93 insertions(+), 10 deletions(-)
>
> Queued, thank you, Frederic!
>
> I have also applied your approach to SRCU, and I applied the following
> to simplify the code a bit -- please let me know if there are any
> problems with this approach.
>
> Thanx, Paul
>
> ------------------------------------------------------------------------
>
> rcu: Remove one layer of abstraction from PROVE_RCU checking
>
> Simplify things a bit by substituting the definitions of the single-line
> rcu_read_acquire(), rcu_read_release(), rcu_read_acquire_bh(),
> rcu_read_release_bh(), rcu_read_acquire_sched(), and
> rcu_read_release_sched() functions at their call points.
>
> Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>

Yeah looks good. Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/