Re: linux-next: Tree for June 23 (net/can & i/o)

From: Stephen Rothwell
Date: Thu Jun 23 2011 - 21:04:29 EST

Hi Mike,

On Thu, 23 Jun 2011 16:38:56 -0400 Mike Frysinger <vapier.adi@xxxxxxxxx> wrote:
> not sure where this is coming from, but some Blackfin boards now fail with:
> drivers/net/can/bfin_can.c: In function 'bfin_can_start_xmit':
> drivers/net/can/bfin_can.c:247: error: implicit declaration of function 'writew'
> make[3]: *** [drivers/net/can/bfin_can.o] Error 1

yeah, caused by the removal of the inclusion of mm.h from netdevice.h
(most probably).

> at any rate, the usage of writew() in this driver is wrong, so i sent
> a patch to fix it. but since nothing in this file nor in my Blackfin
> tree changed, i wonder if whatever common code changed is going to
> break other stuff ...

It did indeed :-(

ah, well, I guess that is what I am here for :-)
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx

Attachment: pgp00000.pgp
Description: PGP signature