Re: [PATCH] char drivers: Ram oops kernel configuration parameters

[Mandeep Singh Baines]

On Thu, Jun 23, 2011 at 2:33 PM, Greg KH <gregkh@xxxxxxx> wrote:
> On Thu, Jun 23, 2011 at 01:43:49PM -0700, Sergiu Iordache wrote:
>> On Thu, Jun 23, 2011 at 12:59 PM, <Valdis.Kletnieks@xxxxxx> wrote:
>> > On Thu, 23 Jun 2011 11:36:00 PDT, Sergiu Iordache said:
>> > > Ramoops currently has module parameters for setting the configuration
>> > > variables (ram start, ram size and dump oopses). This makes it difficult to
>> > > configure when the module is compiled as a builtin.
>> >
>> > Can't you add 'ramoops.ram_start=128M ramoops.ram_size=64M' or similar
>> > to your kernel cmdline?
>>
>> You can but the problem is that when you're using the module as a
>> builtin managing the command line is harder than managing Kconfig
>> files. Instead of having different platform dependent config files
>> (which already exist in most of the cases) under source control you
>> would have to have different scripts which run the kernel with
>> different parameters.
>
> Then why not make the sysfs files writable?
>

We do use sysctl and sysfs for most of our tuning stuff.

But in this case, you wouldn't be able to write the sysfs file until
late in boot
so an early crashed would be lost.

Our command-line is pretty generic across targets. Even across archs.

> Stuff like this should not be picked from the configuration build if at
> all possible.  The fact that you feel changing the Kconfig is easier
> than your boot command line shows a problem in your overall system
> configuration.
>
> greg k-h
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/