[PATCH 11/11] spi-dw: remove noop else clause

From: dirk . brandewie
Date: Wed Jun 22 2011 - 22:01:15 EST


From: Dirk Brandewie <dirk.brandewie@xxxxxxxxx>

The value of spi->bits_per_word is checked on function entry to be 8
or 16. The else clause has no meaning since it can never be reached.

Signed-off-by: Dirk Brandewie <dirk.brandewie@xxxxxxxxx>
---
drivers/spi/spi-dw.c | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c
index 7b3f607..5ddd45f 100644
--- a/drivers/spi/spi-dw.c
+++ b/drivers/spi/spi-dw.c
@@ -667,17 +667,14 @@ static int spi_dw_setup(struct spi_device *spi)
chip->enable_dma = chip_info->enable_dma;
}

- if (spi->bits_per_word <= 8) {
+ if (spi->bits_per_word == 8) {
chip->n_bytes = 1;
chip->dma_width = 1;
- } else if (spi->bits_per_word <= 16) {
+ } else if (spi->bits_per_word == 16) {
chip->n_bytes = 2;
chip->dma_width = 2;
- } else {
- /* Never take >16b case for DW SPIC */
- dev_err(&spi->dev, "invalid wordsize\n");
- return -EINVAL;
}
+
chip->bits_per_word = spi->bits_per_word;

chip->speed_hz = spi->max_speed_hz;
--
1.7.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/