Re: [PATCH 1/3] ideapad: define cfg bits and create sysfs node forcfg

From: Matthew Garrett
Date: Wed Jun 22 2011 - 15:35:33 EST

On Wed, Jun 22, 2011 at 04:05:43PM +0800, Ike Panhc wrote:
> static int __devinit ideapad_acpi_add(struct acpi_device *adevice)
> {
> - int ret, i, cfg;
> + int ret, i;
> + unsigned long cfg;

You change this to an unsigned long, but you cast it to an int in
several places. Is that just to avoid casting to a long here?

> - if (test_bit(ideapad_rfk_data[i].cfgbit, (unsigned long *)&cfg))
> + if (test_bit(ideapad_rfk_data[i].cfgbit, &cfg))

I think it seems neater the other way around, but don't have terribly
strong opinions.

Matthew Garrett | mjg59@xxxxxxxxxxxxx
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at