Re: [PATCH v2 1/4] Exynos4 NURI: configure regulators and PMIC

From: Tushar Behera
Date: Tue Jun 21 2011 - 01:33:28 EST

On Tuesday 21 June 2011 07:37 AM, MyungJoo Ham wrote:
Signed-off-by: MyungJoo Ham<myungjoo.ham@xxxxxxxxxxx>
Signed-off-by: Kyungmin Park<kyungmin.park@xxxxxxxxxxx>

Changes from v1. Thanks so much for your valuable comments, Mark.
- Removed unnecessary initialization data
- Add __initdata where necessary
- Corrected a regulator name for ADC
arch/arm/mach-exynos4/mach-nuri.c | 622 ++++++++++++++++++++++++++++++++++++-
1 files changed, 621 insertions(+), 1 deletions(-)

Will it be possible to move PMIC specific defines to a common file and make appropriate calls in the board-specific file?

In that way, we can re-use this PMIC code on some other boards (e.g. Insignal low-cost board Origen featuring Exynos4210 also features MAX8997).

Tushar Behera
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at