Re: [PATCH] USB: ehci: use packed,aligned(4) instead of removing thepacked attribute

From: Nicolas Pitre
Date: Mon Jun 20 2011 - 16:28:54 EST

On Mon, 20 Jun 2011, Arnd Bergmann wrote:

> On Monday 20 June 2011 19:39:34 Alexander Holler wrote:
> > That packed without an additional aligned() caused errors on ARM with
> > gcc 4.6 is another problem which got (currently) fixed by removing packed.
> Packed caused errors because it is *wrong*. The code as it was used undefined
> behavior in the language.

I wouldn't call this issue as such, but this is a Red herring.

Could you please provide a pointer to the structure definition so a
second opinion to the usefulness of __packed there could be provided?
If it is not matching any of the fairly limited cases where having
__packed is relevant then we can just confirm that it should go.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at