Re: [PATCH] cfq: Remove special treatment for metadata rqs.

From: Jens Axboe
Date: Mon Jun 20 2011 - 16:05:50 EST


On 2011-06-20 22:03, Justin TerAvest wrote:
> On Mon, Jun 20, 2011 at 12:59 PM, Jens Axboe <jaxboe@xxxxxxxxxxxx> wrote:
>> On 2011-06-20 21:52, Justin TerAvest wrote:
>>> There is no consistency among filesystems from what bios (or requests)
>>> are marked as being metadata. It's interesting to expose this in traces,
>>> but we shouldn't schedule the requests differently based on whether or
>>> not they're marked as being metadata.
>>
>> Agree, we should kill that. What is this patch against? cfq_choose_req()
>> also has a "choose meta over non-meta" preference.
>
> This is against for-3.1. Let me know if you want it against something else.

Great, right branch.

> Sorry, I missed the preference in cfq_choose_req, since it changed to
> be clever about bit operations. I'll send a v2 patch that cleans that
> use up as well.

Thanks!

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/