Re: [PATCH] USB: ehci: use packed,aligned(4) instead of removingthe packed attribute

From: Alexander Holler
Date: Mon Jun 20 2011 - 14:46:39 EST


Am 20.06.2011 20:39, schrieb Alan Stern:
On Mon, 20 Jun 2011, Alexander Holler wrote:

I see it that way: packed is needed to be sure that at least for struct
ehci_regs there are no padding bytes inbetween the members.

But is it _really_ needed?

It might
work without, but that depends on the compiler (-version, architecture,
whatever).

Have there _ever_ been _any_ combinations of compiler, version,
architecture, whatever, that had unwanted padding bytes in this
structure?

I don't know. But if there would be no doubts, this discussion would not happen and I assume there never would have been an attribute packed there.

Regards,

Alexander
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/