Re: [PATCH] USB: ehci: use packed,aligned(4) instead of removingthe packed attribute

From: Alan Stern
Date: Mon Jun 20 2011 - 13:35:41 EST

On Mon, 20 Jun 2011, Nicolas Pitre wrote:

> Are we talking past each other?
> Remember that I was the one asking if the align attribute was needed in
> the first place. If it is not then by all means please get rid of it!
> But if it _is_ needed, then the generated code can be much better if the
> packed attribute is _also_ followed by the align attribute to
> increase it from 1.

According to Arnd, any remaining possible issues will be addressed by
changing the implementation of readl/writel on ARM. It doesn't look as
though the ehci files need anything else done.

As far as I can tell, the other structures in ehci.h have
((aligned(32)) simply in order to save space, since there can be large
numbers of these structures allocated. That doesn't apply to the
structures in ehci_def.h; there will only be one of each.

Alan Stern

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at