Re: [PATCH] s3c2410_udc: fix custom UDC command handling

From: Felipe Balbi
Date: Mon Jun 20 2011 - 13:35:06 EST


On Mon, Jun 20, 2011 at 07:27:18PM +0200, Viliam Mateicka wrote:
> I wonder then, who applies the patch first. One ass can't stop
> progress (was there some progress afterall ?) because of one
> line-break (which git produces by default afterall) and several
> non-conforming whitespace conversions. I think you should stop
> replying to me, because I'm kinda starting to like trolling afterall.

Look, maybe you're just new to git/linux and that's fine. The only
problem we had from day one is that you have been a complete dick when

If you go that road, that's what you'll get in return.

Just so you see the properly formatted patch, I'm quoting below. See
that there's no line breaks introduced by git.

commit c27c9b5312f4b2a7e66ee772943355d77fc2c550
Author: Viliam Mateicka <viliam.mateicka@xxxxxxxxx>
Date: Mon Jun 20 19:08:27 2011 +0300

usb: gadget: s3c2410_udc: fix custom UDC command handling

There is a bug in Samsung's UDC driver, which is
completely disabling the USB device when a custom
UDC command is used.

Following patch seems to get the right behavior
(e.g. enabling pull-up instead of disabling then
Vcc is applied).

Signed-off-by: Viliam Mateicka <viliam.mateicka@xxxxxxxxx>

[ balbi@xxxxxx : manually re-created the patch because
author was unable to send a proper one ]

Signed-off-by: Felipe Balbi <balbi@xxxxxx>

diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c
index 100f263..b6e1ca5 100644
--- a/drivers/usb/gadget/s3c2410_udc.c
+++ b/drivers/usb/gadget/s3c2410_udc.c
@@ -1567,7 +1567,7 @@ static void s3c2410_udc_command(enum s3c2410_udc_cmd_e cmd)

if (udc_info->udc_command) {
- udc_info->udc_command(S3C2410_UDC_P_DISABLE);
+ udc_info->udc_command(cmd);
} else if (gpio_is_valid(udc_info->pullup_pin)) {
int value;

(if you see any line breaks that's your mailer, it's better to check
from the archives [1])



Attachment: signature.asc
Description: Digital signature