Re: [PATCH 2/3] mm: make the threshold of enabling THP configurable

From: Cong Wang
Date: Mon Jun 20 2011 - 13:17:15 EST

ä 2011å06æ21æ 00:59, Mel Gorman åé:
On Tue, Jun 21, 2011 at 12:34:29AM +0800, Amerigo Wang wrote:
Don't hard-code 512M as the threshold in kernel, make it configruable,
and set 512M by default.

I'm not seeing the gain here either. This is something that is going to
be set by distributions and probably never by users. If the default of
512 is incorrect, what should it be? Also, the Kconfig help message has
spelling errors.

Sorry for spelling errors, I am not an English speaker.

Hard-coding is almost never a good thing in kernel, enforcing 512
is not good either. Since the default is still 512, I don't think this
will affect much users.

I do agree to improve the help message, like Dave mentioned in his reply,
but I don't like enforcing a hard-coded number in kernel.

BTW, why do you think 512 is suitable for *all* users?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at