Re: [PATCH] USB: ehci: use packed,aligned(4) instead of removing the packed attribute

From: Arnd Bergmann
Date: Sun Jun 19 2011 - 16:12:24 EST

On Sunday 19 June 2011 22:02:23 Arnd Bergmann wrote:
> In this case, we would have to do
> struct s {
> char c[2];
> } __packed;
> struct t {
> struct s t1;
> unsigned short t2[3] __aligned(2);
> } __packed;
> To tell the compiler that t2 is indeed aligned, while struct t
> is packed to include no padding around t.
> I actually recently stumbled over code that gets this wrong,
> see

Just to be clear: none of the ehci structures fall into this category.
I would assume that we actually have a few more drivers with this
bug in the kernel, but the patch proposed by Alexander would not
help with this problem, and the EHCI driver is still correct without

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at