Re: [PATCH] gigaset: call module_put before restart of if_open()

From: David Miller
Date: Fri Jun 17 2011 - 15:28:41 EST

From: Pavel Shved <shved@xxxxxxxxx>
Date: Fri, 17 Jun 2011 20:25:11 +0400

> if_open() calls try_module_get(), and after an attempt to lock a mutex
> the if_open() function may return -ERESTARTSYS without
> putting the module. Then, when if_open() is executed again,
> try_module_get() is called making the reference counter of THIS_MODULE
> greater than one at successful exit from if_open(). The if_close()
> function puts the module only once, and as a result it can't be
> unloaded.
> This patch adds module_put call before the return from if_open().
> Found by Linux Driver Verification project (
> Signed-off-by: Pavel Shved <shved@xxxxxxxxx>

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at