Re: input regression

From: Ortwin Glück
Date: Thu Jun 16 2011 - 03:44:16 EST

On 15.06.2011 17:03, Greg KH wrote:
> On Wed, Jun 15, 2011 at 09:16:47AM +0200, Ortwin Glück wrote:
>> Hi Greg,
>> This patch in breaks magicmouse support for me completely.
>> a5ccaac64c17ce3cc1878a6d479a6f1b16092c24
>> HID: magicmouse: ignore 'ivalid report id' while switching modes
>> The device will no longer work at all:
>> magicmouse 0005:05AC:030D.0005: input,hidraw2: BLUETOOTH HID v0.84 Mouse
>> [gandalf mouse] on 7C:6D:62:9F:DB:2D
>> magicmouse 0005:05AC:030D.0005: unable to request touch data (2)
>> Fine in previous kernels.
> This has been discussed already, and it should be fixed in Linus's tree
> right now, right?
> If so, can someone please send stable@xxxxxxxxxx the proper fix for
> this?
> thanks,
> greg k-h

If it's in Linus' tree then I can't find it. To me this issue just looks
like a silly typo anyway:

- if (ret != sizeof(feature)) {
+ if (ret != -EIO) {
hid_err(hdev, "unable to request touch data (%d)\n", ret);
goto err_stop_hw;

Should this not be (ret == -EIO)?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at