Re: [PATCH] do_coredump: fix the "ispipe" error check

From: Neil Horman
Date: Tue Jun 07 2011 - 15:09:11 EST


On Tue, Jun 07, 2011 at 08:35:42PM +0200, Oleg Nesterov wrote:
> do_coredump() assumes that if format_corename() fails it should
> return -ENOMEM. This is not true, for example cn_print_exe_file()
> can propagate the error from d_path. Even if it was true, this is
> too fragile. Change the code to check "ispipe < 0".
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
> ---
>
> fs/exec.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> --- ptrace/fs/exec.c~corename_errcode 2011-06-07 19:44:30.000000000 +0200
> +++ ptrace/fs/exec.c 2011-06-07 20:20:48.000000000 +0200
> @@ -2092,16 +2092,16 @@ void do_coredump(long signr, int exit_co
>
> ispipe = format_corename(&cn, signr);
>
> - if (ispipe == -ENOMEM) {
> - printk(KERN_WARNING "format_corename failed\n");
> - printk(KERN_WARNING "Aborting core\n");
> - goto fail_corename;
> - }
> -
> if (ispipe) {
> int dump_count;
> char **helper_argv;
>
> + if (ispipe < 0) {
> + printk(KERN_WARNING "format_corename failed\n");
> + printk(KERN_WARNING "Aborting core\n");
> + goto fail_corename;
> + }
> +
> if (cprm.limit == 1) {
> /*
> * Normally core limits are irrelevant to pipes, since
>
>
Looks good. Thanks!
Reviewed-by: Neil Horman <nhorman@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/