Re: [tip:core/debug] debug: Make CONFIG_EXPERT selectCONFIG_DEBUG_KERNEL to unhide debug options

[Ingo Molnar]

* Josh Triplett <josh@xxxxxxxxxxxxxxxx> wrote:

> On Tue, Jun 07, 2011 at 12:18:51PM +0200, Ingo Molnar wrote:
> > 
> > * Josh Triplett <josh@xxxxxxxxxxxxxxxx> wrote:
> > 
> > > On Mon, Jun 06, 2011 at 11:45:04PM +0200, Frederic Weisbecker wrote:
> > > > On Mon, Jun 06, 2011 at 09:39:40PM +0000, tip-bot for Josh Triplett wrote:
> > > > > Commit-ID:  2458073da04571182748aa4289630dca52ba63cc
> > > > > Gitweb:     http://git.kernel.org/tip/2458073da04571182748aa4289630dca52ba63cc
> > > > > Author:     Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> > > > > AuthorDate: Mon, 6 Jun 2011 09:51:30 -0700
> > > > > Committer:  Ingo Molnar <mingo@xxxxxxx>
> > > > > CommitDate: Mon, 6 Jun 2011 19:30:01 +0200
> > > > > 
> > > > > debug: Make CONFIG_EXPERT select CONFIG_DEBUG_KERNEL to unhide debug options
> > > > > 
> > > > > Several debugging options currently default to y, such as
> > > > > CONFIG_DEBUG_BUGVERBOSE and CONFIG_DEBUG_RODATA.
> > > > > 
> > > > > Embedded users might want to turn those options off to save space;
> > > > > however, turning them off requires turning on CONFIG_DEBUG_KERNEL to
> > > > > unhide them.  Since CONFIG_DEBUG_KERNEL exists specifically to
> > > > > unhide debugging options, and CONFIG_EXPERT exists specifically
> > > > > to unhide options potentially needed by experts and/or embedded
> > > > > users, make CONFIG_EXPERT automatically imply CONFIG_DEBUG_KERNEL.
> > > > > 
> > > > > Change various debugging options to only reference DEBUG_KERNEL,
> > > > > not EXPERT.
> > > > > 
> > > > > Note that DEBUG_MEMORY_INIT defaulted to !EXPERT, which seemed
> > > > > wrong, since EXPERT should not directly affect anything except
> > > > > the availability of other options.  (And EXPERT definitely
> > > > > shouldn't mean "implicitly turn off default safety features".)
> > > > > 
> > > > > Change it to default to y, which means that turning on EXPERT
> > > > > does not automatically disable it, but will provide the option
> > > > > to disable it.
> > > > > 
> > > > > Signed-off-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> > > > > Acked-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> > > > 
> > > > No, Nacked actually. I'm fine with the v2 that only changed
> > > > the EXPERT config to imply DEBUG_KERNEL. But all the other
> > > > changes here need to be revised, as I outlined in the thread.
> > > 
> > > Fixed in v4; please replace the patch in tip with that.
> > 
> > i applied the much simpler v2 twoliner version instead.
> 
> OK...
> 
> So, should I prepare a separate patch which changes the instances 
> of DEBUG_KERNEL && EXPERT, or just leave them?

Yeah, would be nice to send a separate patch for that - 'DEBUG_KERNEL 
&& EXPERT' is equivalent to EXPERT now, right?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/