Re: [PATCH v2] spi: reorganize drivers

From: Mike Frysinger
Date: Tue Jun 07 2011 - 00:37:04 EST


On Tue, Jun 7, 2011 at 00:32, Tomoya MORINAGA wrote:
> (2011/06/07 1:52), Grant Likely wrote:
>> Hahaha. ÂOops, I can't remember the conversation I had 5 minutes after
>> getting off the phone.
>>
>> It should actually be Tomoya who can comment on the name change.
>
> As far as I know, this change doesn't occur any issue.
> However, I don't have perfect confidence about it.
> Could you give me any information about concern ?

KBUILD_MODNAME is automatically expanded from the file name. so any
code using KBUILD_MODNAME cannot be renamed with 0 side effects. the
question is whether the changed string makes a difference to the
driver.

so if the places where KBUILD_MODNAME is used doesn't actually care
about the contents of the string (and is purely for information
purposes only), then there shouldnt be a problem. but if there is
implicit lookups/matching based on the string, then this is a problem.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/