Re: [PATCH 3/5] CFQ: rename ioc_data to last_cic

From: Paul Bolle
Date: Mon Jun 06 2011 - 15:13:21 EST


On Mon, 2011-06-06 at 05:02 +0200, Jens Axboe wrote:
> It's really io scheduler agnostic, but cfq is the only user. Lets leave
> the flexibility there.

So that agnosticism and flexibility is unused right now. This might
again have to do with my perspective, but understanding that
ioc->ioc_data

(which really is rather opaque) basically meant (something like)
ioc->cic_last

was a bit of an eye opener for me. But you have to maintain this code,
which makes this your decision, obviously.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/