Re: [debug patch] printk: Add a printk killswitch to robustify NMIwatchdog messages

From: Peter Zijlstra
Date: Mon Jun 06 2011 - 13:12:14 EST


On Mon, 2011-06-06 at 19:07 +0200, Ingo Molnar wrote:
> * Arne Jansen <lists@xxxxxxxxxxxxxx> wrote:
>
> > > As long as it doesn't scramble the order of the messages, the
> > > delay imho doesn't matter even in very printk-heavy debugging
> > > sessions.
> >
> > And, as important, doesn't reduce the throughput of printk. Having
> > only 100 wakeups/s sounds like the throughput is limited to
> > 100xsizeof(ring buffer).
>
> Nah.
>
> I for example *always* kill klogd during such printk based debugging
> sessions, because it's *already* very easy to overflow its buffering
> abilities. Also, klogd often interferes with debugging.

Also, klogd is completely irrelevant, klogd doesn't do anything useful.
Writing things to the actual console otoh is very useful (you get to see
them on the screen/serial line).

Delaying the console_sem release will delay anything touching the
console_sem, including userland stuffs.

Delaying the console_sem acquire+release will delay showing important
printk() lines on your serial.

Both suck.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/