Re: [PATCH v2] spi: reorganize drivers

From: Grant Likely
Date: Mon Jun 06 2011 - 12:53:16 EST


On Mon, Jun 6, 2011 at 10:49 AM, Dirk Brandewie
<dirk.brandewie@xxxxxxxxx> wrote:
> On 06/06/2011 09:38 AM, Grant Likely wrote:
>>
>> On Mon, Jun 6, 2011 at 10:31 AM, Mike Frysinger<vapier.adi@xxxxxxxxx>
>>  wrote:
>>>
>>> On Mon, Jun 6, 2011 at 03:18, Grant Likely wrote:
>>>>
>>>> Sort the SPI makefile and enforce the naming convention spi_*.c for
>>>> spi drivers.
>>>
>>> spi_topcliff_pch.c uses KBUILD_MODNAME with a few funcs, but perhaps
>>> those are only for /proc/ status tracking ?  worth double checking ...
>>
>> I just talked with Dirk Brandewie, who has a major rewrite to the
>> topcliff spi driver.  I'll let him comment on whether or not changing
>> KBUILD_MODNAME will cause any problems.
>>
>
> My changes are to the designware driver :-) I will get my patches re-based
> onto the spi-next branch and see if there any issues.

Hahaha. Oops, I can't remember the conversation I had 5 minutes after
getting off the phone.

It should actually be Tomoya who can comment on the name change.

g.


--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/