Re: [PATCH 4/6] MAINTAINERS: Remove unused PERFORMANCE EVENTS pattern

From: Ingo Molnar
Date: Thu Jun 02 2011 - 05:06:45 EST



* Joe Perches <joe@xxxxxxxxxxx> wrote:

> On Thu, 2011-06-02 at 09:40 +0200, Ingo Molnar wrote:
> > * Joe Perches <joe@xxxxxxxxxxx> wrote:
> > > No arch/*/lib/perf_event* files exist so remove the pattern.
> > The arch/*/lib/ hierarchy is a common place to put stuff into, it
> > does not hurt at all to have it mentioned.
>
> Every once in awhile I run a script on MAINTAINERS
> and fix up defects found by the script.
>
> Dead code is dead code.
> This was unused as of commit e360adbe2924.

NAK, i've outlined my reasons:

- It's an obvious pattern to put librarized functionality in there
and should an architecture grow a file there in the future it
will be included automatically.

- What we are interested in are false positives (files included that
should not be matched) and false negatives (files belonging to a
subsystm not included) - this pattern is none of those.

> > stop mucking with these patterns and start dealing with some of
> > the more important problems we have?
>
> My time, my choice on what to do with it.

Yes, but this time you are also wasting my time with such a stupid
patch, so it's not just your time wasted anymore.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/