Re: [PATCH 11/17] ptrace: implement PTRACE_SEIZE

From: Oleg Nesterov
Date: Wed Jun 01 2011 - 15:57:04 EST


On 06/01, Oleg Nesterov wrote:
>
> On 05/30, Tejun Heo wrote:
> >
> > * If PTRACE_SEIZE'd, group stop uses PTRACE_EVENT_STOP trap which uses
> > exit_code of (SIGTRAP | PTRACE_EVENT_STOP << 8) instead of the
> > stopping signal number
>
> Hmm. May be it would be better to report stopping_signal | PTRACE_EVENT_STOP
> instead... I am not sure yet, but it seems this way we can avoid the
> PTRACE_GETSIGINFO changes. I'll try to explain later, when I finsh the
> reading.

Tomorrow. I do not see any problems, the whole series looks fine to me.
Except I have some minor concerns which I need to re-check and summarize.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/