Re: [PATCH 2/3] UBIFS: intialize the LPT earlier

From: Artem Bityutskiy
Date: Wed Jun 01 2011 - 06:11:20 EST


Hi,

thanks for the patch, however

On Mon, 2011-05-30 at 14:56 -0400, Ben Gardiner wrote:
> + err = ubifs_lpt_init(c, 1, !c->ro_mount);
> + if (err)
> + goto out_lpt;

You cannot call ubifs_lpt_init()

> +
> if ((c->mst_node->flags & cpu_to_le32(UBIFS_MST_DIRTY)) != 0) {
> ubifs_msg("recovery needed");
> c->need_recovery = 1;
> if (!c->ro_mount) {
> err = ubifs_recover_inl_heads(c, c->sbuf);

Before ubifs_recover_inl_heads() is called in case of dirty FS.

I've massaged your patch and pushed the following analogous patch to the
ubifs tree, please check/test: