RE: [PATCH] 8250_pci: add -ENODEV code for Intel EG20T PCH

From: Tomoya MORINAGA
Date: Mon May 30 2011 - 07:19:48 EST


Hi Greg

> Because if the PCH driver is not available you want to bind
> it to the 8250 driver, which also works with it but less efficiently.
>
> The giant if probably should be a pci match table however

Which opinions should I select ?

Though Alan's comment has a point,
IMHO, in probe processing, the efficiently is not so important.
Adding the "#ifdef", I think, readability of 8250_pci.c goes down.

Thanks,
-----------------------------------------
Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/