Re: [PATCH 07/12] x86, mce: introduce mce_gather_info()

From: Tony Luck
Date: Fri May 27 2011 - 12:29:29 EST


On Fri, May 27, 2011 at 1:00 AM, Ingo Molnar <mingo@xxxxxxx> wrote:
> At minimum an explanation should be put into the code. Small, hidden
> dependencies might be common job security moves in the closed source
> world but this is open source ;-)

Seto-san,

Perhaps this more descriptive comment for you new mce_gather_info()
function would help:

/*
* Collect all global (w.r.t. this processor) status about this machine
* check into our "mce" struct so that we can use it later to assess
* the severity of the problem as we read per-bank specific details.
*/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/