RE: pch_gpio: Support new device ML7223

From: Tomoya MORINAGA
Date: Wed May 25 2011 - 21:25:03 EST


> From: Alexander Stein [mailto:alexander.stein@xxxxxxxxxxxxxxxxxxxxx]
> Sent: Wednesday, May 25, 2011 9:10 PM

> > #define pch_gpio_resume NULL #endif
> >
> > +#define PCI_VENDOR_ID_ROHM 0x10DB
>
> Should this be moved to pci_ids.h?
OK.
I will move this to pci_ids.h.

>
> > static DEFINE_PCI_DEVICE_TABLE(pch_gpio_pcidev_id) = {
> > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x8803) },
> > + { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8014) },
>
> Likewise for the product ID. While at it, the ID for EG20T
> could also be moved in a separate patch.

We have already upstreamed not only GPIO but also many device drivers(GBE, USBDEV,DMA,UART,SPI,I2C,CAN).
Do you mean we must move these device definitions to pci_ids.h?

Thanks,
-----------------------------------------
Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/