Re: [PATCH] SCSI IOCTL: Check for device deletion [was Re:__elv_add_request OOPS]

From: Linus Torvalds
Date: Wed May 25 2011 - 19:53:38 EST


On Wed, May 25, 2011 at 4:45 PM, Parag Warudkar <parag.lkml@xxxxxxxxx> wrote:
>
> So now the issue is with scsi_device refcnt?

No, I'd guess that the problem is just that __scsi_remove_device()
sets queuedata to NULL. Afaik, both sdev and the queue actually stay
around.

That said, I don't have very high opinions of some of the SCSI code.
And that's me being polite. The thing is a overcomplicated mess of
indirection and pointers back-and-forth. The refcounting is crazy
and/or impossible, since the pointers really do go back-and-forth.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/