Re: [v3 00/39] faster tree-based sysctl implementation

[Lucian Adrian Grijincu]

On Mon, May 23, 2011 at 7:27 AM, Eric W. Biederman
<ebiederm@xxxxxxxxxxxx> wrote:
> I will mention a couple of nits I noticed while I was skimming through
> your patches.
> - There can be multiple proc superblocks and thus multiple inodes
> Âreferring to the same /proc/sys file, if there are multiple pid
> Ânamespaces.


OK. I'll revert the patch that make converts an int counter into an u8
and post an update. I guess this is what you were referring to.
https://github.com/luciang/linux-2.6-new-sysctl/commit/b7a547b8ce7484ae22eea34a860f674fcb19c11b


> - I have a hope to move /proc/sys into /proc/<pid>/sys so we don't have
> Âto look at current to determine the namespace we want to display.
> ÂThat would allow the deeply magic sysctl_is_seen check to be removed
> Âfrom proc_sys_compare. ÂThat is not your problem, but of an
> Âexplanation why the namespaces are passed through.


OK, I'll go an change things to pass the current namespace as it were
before my changes.


Thank you.
-- 
Â.
..: Lucian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/