Re: kernel 2.6.39 (user mode linux) crashes (2.6.38 works fine)

From: richard -rw- weinberger
Date: Sat May 21 2011 - 06:12:36 EST


2011/5/21 Toralf Förster <toralf.foerster@xxxxxx>:
> Bisecting gave :
>
>
> git bisect badd123375425d7df4b6081a631fc1203fceafa59b2 is the first bad commit
> commit d123375425d7df4b6081a631fc1203fceafa59b2
> Author: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Date:   Wed Jan 26 21:32:01 2011 +0100
>
>    rwsem: Remove redundant asmregparm annotation
>
>    Peter Zijlstra pointed out, that the only user of asmregparm (x86) is
>    compiling the kernel already with -mregparm=3. So the annotation of
>    the rwsem functions is redundant. Remove it.

Ok, this bisect makes much more sense.

Thomas, Peter, please revert d123375425d7df4b6081a631fc1203fceafa59b2.
We cannot compile UML with -mregparm=3 it would cause a lot of trouble.
It would break 32bit UML on 64bit and also on older 32bit systems like RHEL5.

--
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/