Re: Fw: [PATCH -next RESEND/still needed] staging: altera-jtag needsdelay.h

From: Mauro Carvalho Chehab
Date: Thu May 19 2011 - 15:22:20 EST


Em 28-03-2011 12:23, Randy Dunlap escreveu:
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>
> altera-jtag.c needs to include <linux/delay.h> to fix a build error:
>
> drivers/staging/altera-stapl/altera-jtag.c:398: error: implicit declaration of function 'udelay'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
Acked-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>

> Cc: Igor M. Liplianin <liplianin@xxxxxxxx>
> ---
> drivers/staging/altera-stapl/altera-jtag.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Somehow I was supposed to know to send this to Mauro instead of to Greg,
> but I don't see anything in drivers/staging/altera-stapl/ that says that.

Ah, yes, we need to add a readme file there stating about that.

Greg, you may add it on your tree, or if you prefer, I can just add here for
my next upstream pull.

Thanks,
Mauro.

>
>
> --- linux-next-20110304.orig/drivers/staging/altera-stapl/altera-jtag.c
> +++ linux-next-20110304/drivers/staging/altera-stapl/altera-jtag.c
> @@ -23,6 +23,7 @@
> * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
> */
>
> +#include <linux/delay.h>
> #include <linux/firmware.h>
> #include <linux/slab.h>
> #include <staging/altera.h>
> --

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/