Re: [PATCH 02/10] mach-u300: rewrite gpio driver, move to drivers/gpio

From: Barry Song
Date: Thu May 19 2011 - 07:38:53 EST


> -arch_initcall(u300_gpio_init);
> -module_exit(u300_gpio_exit);
>
looks like the driver can't be a real module, is the module_exit
suitable? it looks strange module_exit plays together with
arch_initcall.
guess symbol u300_gpio_exit will finally lose in the last vmlinux
since it is in exit section and built-in kernel.

another problem i see is after moving gpio/pinmux to drivers as
platform device, codes in arch/arm/plat(mach) can't call gpio/pinmux
api before the related platform devices registerred. that will
required these platform devices enter system earlier.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/