Re: [PATCH] tracing: Register static events output early

[Frederic Weisbecker]

On Wed, May 18, 2011 at 07:37:19PM -0400, Steven Rostedt wrote:
> On Thu, 2011-05-19 at 01:29 +0200, Frederic Weisbecker wrote:
> 
> > diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
> > index cf535cc..ad92d9c 100644
> > --- a/kernel/trace/trace_output.c
> > +++ b/kernel/trace/trace_output.c
> > @@ -1278,4 +1278,4 @@ __init static int init_events(void)
> >  
> >  	return 0;
> >  }
> > -device_initcall(init_events);
> > +early_initcall(init_events);
> 
> Hmm, careful here. The ring buffers are also allocated at early_init().
> 
> But you may be OK, as things like trace_printk() don't do anything if
> "tracing_disabled" is set, and it's set on bootup and cleared after we
> allocate the buffers.

Yep, and the output callback only impact the read side anyway, once the trace
has been already pulled out of the buffer. I hope I'm not missing something in the
way...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/