Re: [patch 2/3] Staging: sm7xx: preferred form for passing a size tomemory allocation routines

From: Greg KH
Date: Wed May 18 2011 - 17:30:40 EST


On Wed, May 18, 2011 at 10:42:08PM +0530, anish wrote:
> The preferred form for passing a size of a struct is the following:
> p = kmalloc(sizeof(*p), ...);
> Please refer Documentation/Codingstyle chapter 14
>
> Signed-off-by: anish kumar <anish198519851985@xxxxxxxxx>
> Acked-by: Harry Wei <harryxiyou@xxxxxxxxx>

What's with the extra spaces at the beginning of the lines?

And I never got patch 1/3 in my inbox.

You also need to put your full name in the "From:" line, like you did
for the signed-off-by: line.

So, care to try again?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/