Re: [PATCH 0/4] Pinmux subsystem

From: Mark Brown
Date: Wed May 18 2011 - 17:22:03 EST


On Wed, May 18, 2011 at 10:02:47PM +0200, Linus Walleij wrote:
> 2011/5/17 Kyungmin Park <kmpark@xxxxxxxxxxxxx>:

> > In this case we only need to set the function at interrupt by like
> > s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(0xf));
> > So pinmux function provides this feature also.

> This function:
> s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(0xf));

> Isn't part of the gpiolib I can see, I am discussing with Grant
> how to handle custom GPIO configuration. Looking in
> archa/arm/plat-samsung/include/plat/gpio-core.h

> it looks like you have your own reimplementation of the
> entire gpiolib in order to get these special configuration
> functions... (So hopefully if I can add custom GPIO
> configs to gpiolib, all of this can move to drivers/gpio/*)

This API predates the generic GPIO API - it's a reimplementation because
at that time the various platforms all had their own custom APIs. The
Samsung specific API is pretty much only used for the pin mux and mode
configuration these days.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/