Re: [PATCH 02/10] job control: introduce JOBCTL_TRAP_STOP and useit for group stop trap

[Oleg Nesterov]

On 05/18, Oleg Nesterov wrote:
>
> So far I can't really understand why do we have both JOBCTL_TRAP_STOP and
> and JOBCTL_TRAPPING... Please ignore, I didn't read other patches yet.

OK, SEIZE sets JOBCTL_TRAP_STOP.

> Hmm. And afaics there is a bug in do_signal_stop(), after
> "[PATCH 6/9] job control: make task_clear_jobctl_pending() clear TRAPPING automatically"
> ->jobctl &= ~JOBCTL_STOP_SIGMASK is no longer safe. We can clear _TRAPPING
> without wakeup.

And this also affects ptrace_attach(PTRACE_SEIZE), TRAP_STOP is cleared
as well.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/