Re: [PATCH 0/4] v6 Improve task->comm locking situation

From: Andrew Morton
Date: Wed May 18 2011 - 03:06:06 EST


On Wed, 18 May 2011 08:25:54 +0200 Ingo Molnar <mingo@xxxxxxx> wrote:

> " Hey, this looks a bit racy and 'top' very rarely, on rare workloads that
> play with ->comm[], might display a weird reading task name for a second,
> amongst the many other temporarily nonsensical statistical things it
> already prints every now and then. "

Well we should at least make sure that `top' won't run off the end of
comm[] and go oops. I think that's guaranteed by the fact(s) that
init_tasks's comm[15] is zero and is always copied-by-value across
fork and can never be overwritten in any task_struct.

But I didn't check that.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/